fix: replace bare except clauses in dataset loading#139
Open
Mr-Neutr0n wants to merge 1 commit intoVchitect:mainfrom
Open
fix: replace bare except clauses in dataset loading#139Mr-Neutr0n wants to merge 1 commit intoVchitect:mainfrom
Mr-Neutr0n wants to merge 1 commit intoVchitect:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Bare
except:clauses in the dataset loading code (datasets/taichi_datasets.py,datasets/sky_datasets.py,datasets/taichi_image_datasets.py,datasets/sky_image_datasets.py) catch all exceptions includingKeyboardInterruptandSystemExit. This silently swallows errors during data loading and makes debugging very difficult.The
tryblocks wrap asorted()call with alambdathat callsint()on parts of the filename. When filenames don't match the expected pattern,int()raisesValueError, which is the only expected exception here.Fix
Replaced bare
except:withexcept ValueError:to only catch the expected exception fromint()conversion failures, allowing unexpected errors to propagate normally.